laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26814 )
Change subject: socket, select: Fix -Wsign-compare warnings ......................................................................
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/c/libosmocore/+/26814/1/src/select.c File src/select.c:
https://gerrit.osmocom.org/c/libosmocore/+/26814/1/src/select.c@319 PS1, Line 319: static int poll_disp_fds(unsigned int n_fd)
it's a bit strange using an unsigned for an fd, it's usually an int right?
n_fd == number of FDs. Cannot be negative.
https://gerrit.osmocom.org/c/libosmocore/+/26814/1/src/socket.c File src/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/26814/1/src/socket.c@213 PS1, Line 213: unsigned int i;
this one should actually be a size_t afaiu.
Ack