28 Feb
2023
28 Feb
'23
1:33 p.m.
Attention is currently required from: neels, fixeria, msuraev, dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31415 )
Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993)
......................................................................
Patch Set 8:
(1 comment)
File include/osmocom/gsm/bts_features.h:
https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/dfc81cd8_142911f5
PS7, Line 39: _TX
In a correctly configured setup we should always see
the same format in both directions.
If you say so... I don't think that's really stated anywhere in the spec, and
sounds like a personal expectancy of what a "correctly configured setup" is imho
😊
I thought the OML feature flags were introduced for
things like this
Yes, to know that a BTS supports a given feature. Not to indicate which of the several
supported is to be used.
BTS model is a PHY based model with TS 101318 support
or an osmo-trx based model with RFC 5993 support.
So our osmo-bts-sysmo is transmitting different RTP type than our osmo-bts-trx? what a
mess! 😮
The BSC knows that it talks to an osmo-bts, but it
does not know if this BTS model
My point is only that you still need to store that in osmo-bsc hardcoded somehow for other
types of BTS, like nanobts, etc. so you could simply do the same for osmobts (you will
need this for older versions of osmo-bts anyway). Maybe that's actually done using
this set of features?
BTS model is a PHY based model with TS 101318 support
or an osmo-trx based model with RFC 5993 support.
So our osmo-bts-sysmo is transmitting different RTP type than our osmo-bts-trx? what a
mess! :O
Extending IPACC can be also a way, here we can at
least be sure that osmo-bts type BTSs will support the extension but we will have to make
sure that older osmo-bts versions will tolerate/ignore the extensions.
Yes, have a look if adding the new IE is really a problem for old versions (I think it
won't be an issue). If it was, then you could add a new BTS feature stating whether
the BTS supports this new IE and then only send it based on it.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043
Gerrit-Change-Number: 31415
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 13:33:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment