Attention is currently required from: laforge, pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared ......................................................................
Patch Set 21:
(2 comments)
File include/osmocom/smpp/smpp.h:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/5e997766_64e5457e PS21, Line 14: esme You marked my comment as resolved without responding.
struct naming seems unclear; we now have struct esme and struct smpp_esme, right? api doc explanation of the difference would be good
File src/utils/Makefile.am:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/57114f65_ac22c05a PS19, Line 45: $(top_builddir)/src/libvlr/libvlr.a \
I completely agree - this problems dates back to BSC/MSC split and the shared gsm_network struct whi […]
struct gsm_network contains opaque pointers to vlr_instance, that shouldn't pull in libvlr as dependency; is it gsm_network_init()? this is not so important, but seems like an easy way out here