Attention is currently required from: pespin, fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30539 )
Change subject: vty: Add support for Ny1 configuration ......................................................................
Patch Set 14:
(3 comments)
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/c35b1c65_511793a3 PS13, Line 50: /* Requirements: We want ny1 to be as low as possible, while respecting T3105 * ny1 > T3124 + delta
isn't it named "Ny1" in the specs? better use same formatting so that people grepping in the code fi […]
It is. I would suppose anyone grepping for abbreviations (especially in C code) would think of going case-insensitive, but I'll change it :)
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/c2ec78d3_b8c33da1 PS13, Line 52: #define GSM_NY1_DEFAULT (unsigned long)((GSM_T3124_MAX + GSM_NY1_REQ_DELTA)/GSM_T3105_DEFAULT + 1)
I meant "to use the cast"
thanks, makes sense. I'll put the parentheses around the expression to keep emphasis on the type at hand.
File tests/nanobts_omlattr/nanobts_omlattr_test.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30539/comment/1bf7c999_d15a2d48 PS13, Line 130: { .T = -3105, .default_val = GSM_NY1_DEFAULT, .val = GSM_NY1_DEFAULT, .min_val = 0, .max_val = UINT8_MAX, .unit = OSMO_TDEF_CUSTOM,
we usually put negative ones at the end
Done