Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: device/websdr: add WebSDR transceiver backend and build target ......................................................................
Patch Set 3:
(1 comment)
File Transceiver52M/device/websdr/TransceiverWebSdr.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/9d598a47_8a816d3b?usp=... : PS3, Line 50: : Transceiver(cfg, wTransmitLatency, wRadioInterface)
I'm not really liking the patch. […]
Thanks for the feedback. My intention was mainly to group everything related to the WebSDR backend into a separate directory. However, you are right that this approach does not fit well with the existing device backend structure.
It makes more sense to move this code into Transceiver52 instead. In fact, in this case I don't really need a radioDevice subclass implementation, so the current layout under device/ is not appropriate. I'll rework the patch accordingly.