Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35672?usp=email )
Change subject: Prevent poll() in select.c to timeout too early
......................................................................
Patch Set 1:
(1 comment)
File src/core/timer.c:
https://gerrit.osmocom.org/c/libosmocore/+/35672/comment/90d9b82a_6bdb986e
PS1, Line 199: nearest_ms += (nearest_p->tv_usec + 999) / 1000;
Ack, maybe it makes sense to round 0->1 to avoid
busy polls, and let the others X.Y ->X.0. […]
If we round down values above 1 ms,
we still have the problem that timers that have a remaining time of more than 1 ms will
cause poll() to exit too early. The result is that the main loop will call the poll()
again, but this time with less than 1 ms, rounded up to 1 ms.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35672?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I79de77c79af4d50d1eb9ca0c5417123ff760dca3
Gerrit-Change-Number: 35672
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Jan 2024 16:14:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment