Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32213
)
Change subject: WIP: Introduce NM FSM for GPRS NSE object
......................................................................
Patch Set 1:
(1 comment)
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32213/comment/5ddbc628_e77407f4
PS1, Line 1467: if (rc < 0)
Maybe check `!= 0` instead? `NM_NACK_OBJINST_UNKN` is
not negative.
ACK good catch.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32213
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I01eadc63214a2eb5e1bce455c7e5b62bd41905ea
Gerrit-Change-Number: 32213
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 05 Apr 2023 10:21:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment