Attention is currently required from: pespin.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34351?usp=email )
Change subject: mgcp_client_fsm: fix inconsistent API (param_present, param). ......................................................................
Patch Set 3:
(6 comments)
File TODO-RELEASE:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10995): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/6ead3e24_95605b7d PS3, Line 29: mgcp NEW API add struct struct mgcp_codec_param2, depreacte struct mgcp_codec_param 'depreacte' may be misspelled - perhaps 'deprecate'?
File include/osmocom/mgcp_client/mgcp_client.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10995): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/91762eba_b7461eca PS3, Line 139: bool param_present; /* Depreacted, please use codecs_param_present */ 'Depreacted' may be misspelled - perhaps 'Deprecated'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10995): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/97f06dbb_ffa2ef8b PS3, Line 140: struct mgcp_codec_param param; /* Depreacted, please use codecs_param */ 'Depreacted' may be misspelled - perhaps 'Deprecated'?
File src/libosmo-mgcp-client/mgcp_client.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10995): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/7053e1fa_927718f1 PS3, Line 1376: LOGPMGW(mgcp, LOGL_NOTICE, "using depreacted struct member mgcp_msg->param, please use mgcp_msg->codecs_param!\n"); 'depreacted' may be misspelled - perhaps 'deprecated'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10995): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/3f5e2528_67706bc8 PS3, Line 1393: if (mgcp_msg->codecs[i] != CODEC_AMR_8000_1 && mgcp_msg->codecs[i] != CODEC_AMRWB_16000_1) suspect code indent for conditional statements (24, 35)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-10995): https://gerrit.osmocom.org/c/osmo-mgw/+/34351/comment/e2e47c09_b920d61c PS3, Line 1394: continue; Statements should start on a tabstop