Attention is currently required from: neels, fixeria, msuraev.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28997 )
Change subject: Add osmo_sock_get_name_multiaddr_buf()
......................................................................
Patch Set 14:
(1 comment)
Patchset:
PS14:
I don't see any advantage in stuffing everything
in a single function - just unnecessary code compli […]
That's precisely the
point. You want to spare difficulties for you while implenting this feature at the expense
of having others having to look at which API to use based on the type of socket.
I disagree with the approach, unless proper reasonings are provided.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28997
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If76595ebd1cf26ba904887a36c4cc14a1b5c4521
Gerrit-Change-Number: 28997
Gerrit-PatchSet: 14
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Oct 2022 12:21:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment