Attention is currently required from: osmith. Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-iuh/+/30081
to look at the new patch set (#3).
Change subject: asn1: fix visibility warnings from generated code ......................................................................
asn1: fix visibility warnings from generated code
Fix warnings from generated asn1 code in order to build osmo-iuh with werror in a future patch:
../../include/osmocom/hnbap/HNBAP_CriticalityDiagnostics-IE-List.h:29:23: error: ‘struct HNBAP_CriticalityDiagnostics_IE_List__Member’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
These visibility warnings come from "SEQUENCE … OF SEQUENCE" definitions in the asn1 source files, as described in detail here: https://github.com/vlm/asn1c/issues/430
It is not possible to tell gcc to just ignore these warnings since they don't have their own type (unlike e.g. -Wuninitialized). Also it seems like a huge effort to patch this in asn1c.
So work around the problem the same way the author of the issue worked around it by rewriting the lines to "SEQUENCE … OF …-Value" and adding a "…-Value ::= SEQUENCE" line below. Add a script in asn1/utils/asn1_restructure_sequence_of_sequence.py for the transformation and apply it.
Related: OS#4462 Change-Id: If84445ed2e0df604b581684dcf83f8520b7da84c --- M asn1/hnbap/HNBAP-IEs.asn M asn1/ranap/RANAP-IEs.asn M asn1/ranap/RANAP-PDU-Contents.asn M asn1/ranap/RANAP-PDU.asn M asn1/rua/RUA-IEs.asn M asn1/sabp/SABP-IEs.asn A asn1/utils/asn1_restructure_sequence_of_sequence.py A include/osmocom/hnbap/HNBAP_CriticalityDiagnostics-IE-List-Value.h M include/osmocom/hnbap/HNBAP_CriticalityDiagnostics-IE-List.h M include/osmocom/hnbap/Makefile.am M include/osmocom/ranap/Makefile.am A include/osmocom/ranap/RANAP_AuthorisedPLMNs-Value.h M include/osmocom/ranap/RANAP_AuthorisedPLMNs.h A include/osmocom/ranap/RANAP_CriticalityDiagnostics-IE-List-Value.h M include/osmocom/ranap/RANAP_CriticalityDiagnostics-IE-List.h A include/osmocom/ranap/RANAP_DataVolumeList-Value.h M include/osmocom/ranap/RANAP_DataVolumeList.h A include/osmocom/ranap/RANAP_EUTRANFrequencies-Value.h M include/osmocom/ranap/RANAP_EUTRANFrequencies.h A include/osmocom/ranap/RANAP_GA-Polygon-Value.h M include/osmocom/ranap/RANAP_GA-Polygon.h A include/osmocom/ranap/RANAP_JoinedMBMSBearerService-IEs-Value.h M include/osmocom/ranap/RANAP_JoinedMBMSBearerService-IEs.h A include/osmocom/ranap/RANAP_LA-LIST-Value.h M include/osmocom/ranap/RANAP_LA-LIST.h A include/osmocom/ranap/RANAP_LeftMBMSBearerService-IEs-Value.h M include/osmocom/ranap/RANAP_LeftMBMSBearerService-IEs.h A include/osmocom/ranap/RANAP_MessageStructure-Value.h M include/osmocom/ranap/RANAP_MessageStructure.h A include/osmocom/ranap/RANAP_PLMNs-in-shared-network-Value.h M include/osmocom/ranap/RANAP_PLMNs-in-shared-network.h A include/osmocom/ranap/RANAP_RABDataVolumeReport-Value.h M include/osmocom/ranap/RANAP_RABDataVolumeReport.h A include/osmocom/ranap/RANAP_RABParametersList-Value.h M include/osmocom/ranap/RANAP_RABParametersList.h A include/osmocom/ranap/RANAP_UnsuccessfulLinking-IEs-Value.h M include/osmocom/ranap/RANAP_UnsuccessfulLinking-IEs.h M include/osmocom/rua/Makefile.am A include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List-Value.h M include/osmocom/rua/RUA_CriticalityDiagnostics-IE-List.h M include/osmocom/sabp/Makefile.am A include/osmocom/sabp/SABP_CriticalityDiagnostics-IE-List-Value.h M include/osmocom/sabp/SABP_CriticalityDiagnostics-IE-List.h A include/osmocom/sabp/SABP_MessageStructure-Value.h M include/osmocom/sabp/SABP_MessageStructure.h A src/hnbap/HNBAP_CriticalityDiagnostics-IE-List-Value.c M src/hnbap/HNBAP_CriticalityDiagnostics-IE-List.c M src/hnbap/Makefile.am M src/ranap/Makefile.am A src/ranap/RANAP_AuthorisedPLMNs-Value.c M src/ranap/RANAP_AuthorisedPLMNs.c A src/ranap/RANAP_CriticalityDiagnostics-IE-List-Value.c M src/ranap/RANAP_CriticalityDiagnostics-IE-List.c A src/ranap/RANAP_DataVolumeList-Value.c M src/ranap/RANAP_DataVolumeList.c A src/ranap/RANAP_EUTRANFrequencies-Value.c M src/ranap/RANAP_EUTRANFrequencies.c A src/ranap/RANAP_GA-Polygon-Value.c M src/ranap/RANAP_GA-Polygon.c A src/ranap/RANAP_JoinedMBMSBearerService-IEs-Value.c M src/ranap/RANAP_JoinedMBMSBearerService-IEs.c A src/ranap/RANAP_LA-LIST-Value.c M src/ranap/RANAP_LA-LIST.c A src/ranap/RANAP_LeftMBMSBearerService-IEs-Value.c M src/ranap/RANAP_LeftMBMSBearerService-IEs.c A src/ranap/RANAP_MessageStructure-Value.c M src/ranap/RANAP_MessageStructure.c A src/ranap/RANAP_PLMNs-in-shared-network-Value.c M src/ranap/RANAP_PLMNs-in-shared-network.c A src/ranap/RANAP_RABDataVolumeReport-Value.c M src/ranap/RANAP_RABDataVolumeReport.c A src/ranap/RANAP_RABParametersList-Value.c M src/ranap/RANAP_RABParametersList.c A src/ranap/RANAP_UnsuccessfulLinking-IEs-Value.c M src/ranap/RANAP_UnsuccessfulLinking-IEs.c M src/rua/Makefile.am A src/rua/RUA_CriticalityDiagnostics-IE-List-Value.c M src/rua/RUA_CriticalityDiagnostics-IE-List.c M src/sabp/Makefile.am A src/sabp/SABP_CriticalityDiagnostics-IE-List-Value.c M src/sabp/SABP_CriticalityDiagnostics-IE-List.c A src/sabp/SABP_MessageStructure-Value.c M src/sabp/SABP_MessageStructure.c 83 files changed, 2,504 insertions(+), 1,695 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/81/30081/3