Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email )
Change subject: Osmocom_CTRL: counters: return -1 for absent objects ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I thought about that actually. […]
IMHO you are adding lots of complexity to regular APIs for a niche use case which should probably be implemented using another adhoc API.
The f_ctrl_get() or f_ctrl_get_ratectr_abs() APIs are clearly to gather values making sure everything is correct. If you are testing some specific case where the counter is not there I think you should specifically test/match for the CTRL ERROR message instead of somehow passing parameters and returning error codes.
That's my opinion right now, if others disagree feel free to merge the patch.