Attention is currently required from: neels.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    I thought about that actually. […]

    IMHO you are adding lots of complexity to regular APIs for a niche use case which should probably be implemented using another adhoc API.

    The f_ctrl_get() or f_ctrl_get_ratectr_abs() APIs are clearly to gather values making sure everything is correct.
    If you are testing some specific case where the counter is not there I think you should specifically test/match for the CTRL ERROR message instead of somehow passing parameters and returning error codes.

    That's my opinion right now, if others disagree feel free to merge the patch.

To view, visit change 37189. To unsubscribe, or for help writing mail filters, visit settings.