Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27938 )
Change subject: coding: fix comments for detect_afs_sid_{first,update,onset} ......................................................................
Patch Set 2:
(1 comment)
File src/coding/gsm0503_amr_dtx.c:
https://gerrit.osmocom.org/c/libosmocore/+/27938/comment/c52a552b_5d0380ac PS2, Line 179: static bool detect_afs_onset(int *n_errors, int *n_bits_total, const ubit_t * ubits)
shouldn't this function be renamed to detect_afs_sid_onset to be like the others?
Actually, it should be just 'ONSET' in the comment without 'SID', because this is how the spec. defines this frame. And no, the function name is correct.