Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/27938 )
Change subject: coding: fix comments for detect_afs_sid_{first,update,onset}
......................................................................
Patch Set 2:
(1 comment)
File src/coding/gsm0503_amr_dtx.c:
https://gerrit.osmocom.org/c/libosmocore/+/27938/comment/c52a552b_5d0380ac
PS2, Line 179: static bool detect_afs_onset(int *n_errors, int *n_bits_total, const ubit_t
* ubits)
shouldn't this function be renamed to
detect_afs_sid_onset to be like the others?
Actually, it should be just
'ONSET' in the comment without 'SID', because this is how the spec.
defines this frame. And no, the function name is correct.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/27938
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef
Gerrit-Change-Number: 27938
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 26 Apr 2022 09:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment