Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email )
Change subject: ASCI: Notify talker in the VTY that he cannot leave the call while
talking
......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/mobile/gsm44068_gcc_bcc.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34906/comment/49bcb13d_ca495d79
PS1, Line 1854: vgcs_vty_notify(trans, "Cannot leave while talking\n");
shouldn't this be returning an error instead of
changing state below?
It returns an error. I moved the statements (as we discussed
in the chat) inside the if-block.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34906?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I497efc5bddc122cd5744de531917aad415ac1654
Gerrit-Change-Number: 34906
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Oct 2023 12:35:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment