[L] Change in osmo-bts[master]: CSD: implement half-rate modes correctly

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email ) Change subject: CSD: implement half-rate modes correctly ...................................................................... Patch Set 2: (4 comments) File include/osmo-bts/csd_v110.h: https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/5c5c8947_3e4f419f?usp… : PS2, Line 11: uint8_t ra2_ir; I can't figure out what this field is about by looking at it, maybe a short comment here helps. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/45fd32a6_fad3fd4a?usp… : PS2, Line 1493: /* TDMA frame number of burst 'a' % 26 is the table index. where does this 26 come from? do we have a define for it? Can we add one? https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/75134c9e_1afbf897?usp… : PS2, Line 1523: if (!sched_tchh_dl_csd_map[fn % 26]) define for 26 to be used here to. https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/7ceea5fd_295a5839?usp… : PS2, Line 2045: * back-to-back every 40 ms on the same frame number, */ why are we sending with same frame number if they have different data? this looks weird. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib35e910df263743cd243f51fb0bd6551ddfcf4c5 Gerrit-Change-Number: 38553 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sun, 27 Oct 2024 19:31:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No