Attention is currently required from: neels.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430 )
Change subject: contrib/jenkins.sh: add PFCP variable
......................................................................
Patch Set 3:
(2 comments)
File contrib/jenkins.sh:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430/comment/d2f59a2d_caf29c18
PS2, Line 9: PFCP=${PFCP:-"--enable-pfcp"}
IMHO it should rather be consistent with
'WITH_MANUALS': […]
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430/comment/78f50568_ddcebf42
PS2, Line 48: =
+= here so that WITH_MANUALS == 1 does not lose the
--enable-pfcp again
oh good catch! fixed
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32430
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Iacc6a0267d4896d0149f5e00d77951cdfc281e4e
Gerrit-Change-Number: 32430
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Apr 2023 08:17:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment