Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/31165
)
Change subject: tunmap: refactor nft ruleset: fix "martians" and
"1024"
......................................................................
Patch Set 6:
(3 comments)
File src/osmo-upf/upf_nft.c:
https://gerrit.osmocom.org/c/osmo-upf/+/31165/comment/66bd78b8_33be991e
PS3, Line 144: uint32_t chain_id;
where's the mark id?
Done
https://gerrit.osmocom.org/c/osmo-upf/+/31165/comment/6f98ad07_f5af02a6
PS3, Line 231: * delete chain inet osmo-upf tunmap-pre-1230
The example above (tunmap_add_single_direction) uses
123 but you use 1230 here.
Done
https://gerrit.osmocom.org/c/osmo-upf/+/31165/comment/2424a285_29ba7ef8
PS3, Line 345: static uint32_t chain_id_next()
(no need to repeat jenkins for me)
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/31165
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Iccb975a1c0f8a2087f7b7dc4942a6b41f5675a13
Gerrit-Change-Number: 31165
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Feb 2023 02:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment