Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/27725 )
Change subject: l1sap: l1sap_chan_act(): alloc DTX FSM only for TCH
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
does this change anytthing in practice or is it merely
cosmetic?
It does.
We don't activate PDCH this way, so it is either a
SDCCH or TCH?
Looks like we do:
src/common/rsl.c: rsl_rx_chan_activ() calls it for all kinds of lchans,
src/common/pcu_sock.c: pcu_rx_act_req() calls it for PDCH lchans.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/27725
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ieb5728b7a9e7d7c58449deaa5a6c4d8755b6e213
Gerrit-Change-Number: 27725
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 13 Apr 2022 14:59:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment