Attention is currently required from: dexter.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41890?usp=email )
Change subject: pySimLogger: user __name__ of the module when creating a new logger ......................................................................
Patch Set 2:
(2 comments)
File contrib/csv-to-pgsql.py:
https://gerrit.osmocom.org/c/pysim/+/41890/comment/5dfca265_536b2b24?usp=ema... : PS1, Line 38: log = PySimLogger.get(__name__)
this is odd, the code should have acces to global variabls of the same module. […]
Indeed, `log` should be accessible globally. Having a dedicated logger just for the `__init__()` method is weird and makes even less sense with this patch applied.
Not blocking here, though. You can address this in a separate patch.
File pySim/card_key_provider.py:
https://gerrit.osmocom.org/c/pysim/+/41890/comment/725711da_08ecf9cb?usp=ema... : PS1, Line 41: PySimLogger.get
I gave this a try, but as it seems it is not the same. […]
I was wrong about inheriting configuration of the parent loggers then. Perhaps you need to configure the `root` logger in `pySim-shell.py` and `pySim-trace.py` then. Anyways, not blocking here. Can be done in a separate patch (I can work on it).