Attention is currently required from: pespin.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email )
Change subject: osmo_iofd_register: fix the case of changing fd
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/39276/comment/d68b7023_d0106d95?… :
PS1, Line 22:
OK, I'll add this notation in the next iteration.
Done
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/39276/comment/1dde1537_45deaf46?… :
PS1, Line 756: else if (iofd->fd < 0)
Right after the `else if` clause I removed, the code
checks `IOFD_FLAG_FD_REGISTERED`. […]
Please look at the new version of my patch.
Following the principle of "leave the campsite cleaner than you found it", I
decided to make a larger restructuring, and now IMO there is a cleaner distinction between
the already-registered case and the more ordinary case of not already registered.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If8b8486ad7934afa203dfe1e996c9217373a017b
Gerrit-Change-Number: 39276
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jan 2025 21:23:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>