[XS] Change in osmo-msc[master]: csd_bs: fix setting of Rate Adaptation for FAX and 3.1 kHz audio

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/38512?usp=email ) Change subject: csd_bs: fix setting of Rate Adaptation for FAX and 3.1 kHz audio ...................................................................... csd_bs: fix setting of Rate Adaptation for FAX and 3.1 kHz audio Some FAX machines, like Siemens based Possia Greta, refuse MT data calls when the Rate Adaptation field is set to GSM48_BCAP_RA_V110_X30. Using GSM48_BCAP_RA_NONE makes the Greta machine happy. After looking at various tables in 3GPP TS 22.002, I deduced that GSM48_BCAP_RA_V110_X30 shall only be used for Unrestricted Digital Information. Use GSM48_BCAP_RA_NONE for both FAX and 3.1 kHz audio. Change-Id: I3d608f412859df8988ce7a51aaef65949c80865b Related: OS#4394, OS#5730 --- M src/libmsc/csd_bs.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/csd_bs.c b/src/libmsc/csd_bs.c index 41747ce..2bd6468 100644 --- a/src/libmsc/csd_bs.c +++ b/src/libmsc/csd_bs.c @@ -429,7 +429,10 @@ for (unsigned int i = 0; i < list->count; i++) { const enum csd_bs bs = list->bs[i]; - cap->data.rate_adaption = GSM48_BCAP_RA_V110_X30; + if (cap->transfer == GSM48_BCAP_ITCAP_UNR_DIG_INF) + cap->data.rate_adaption = GSM48_BCAP_RA_V110_X30; + else /* GSM48_BCAP_ITCAP_3k1_AUDIO or GSM48_BCAP_ITCAP_FAX_G3 */ + cap->data.rate_adaption = GSM48_BCAP_RA_NONE; cap->data.sig_access = GSM48_BCAP_SA_I440_I450; cap->data.async = bs_map[bs].async; if (bs_map[bs].transp) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38512?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3d608f412859df8988ce7a51aaef65949c80865b Gerrit-Change-Number: 38512 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;