Attention is currently required from: laforge, lynxis lazus, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email )
Change subject: gsup: fix wrong ordering of IEs
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I think in general it makes sense to ho have the Message class prior in the message [...]
Ack, I also think so. But it's a rather late addition to GSUP, so this is why we have it there. Not sure if it's really worth introducing potentially breaking changes just to make the IE ordering more logical, though. If we go for it, we would definitely be having problems with the GSUP codec in TTCN-3, which expects a specific order.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I5caa3101da310cddfa311d068ad889bca697b438
Gerrit-Change-Number: 38666
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Tue, 19 Nov 2024 12:31:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de