Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32374 )
Change subject: e1d: reconnect to osmo-e1d after connection loss ......................................................................
Patch Set 1:
(4 comments)
File src/input/e1d.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6062): https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/ab3eda13_14660b36 PS1, Line 96: LOGPFSML(fi, LOGL_NOTICE, "Sucessfully (re)connected to osmo-e1d daemon!\n"); 'Sucessfully' may be misspelled - perhaps 'Successfully'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6062): https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/9b157634_ba44f3fc PS1, Line 105: } void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6062): https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/a0a5714a_5dbd450f PS1, Line 122: LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "Loosing osmo-e1d connection to timeslot: %d\n", ts); 'Loosing' may be misspelled - perhaps 'Losing'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-6062): https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/6ec9cc59_74ffe45a PS1, Line 193: } void function return statements are not generally useful