Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30126 )
Change subject: [codecs filter] use filter result in Assignment ......................................................................
Patch Set 4:
(1 comment)
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/30126/comment/d53fd5b4_bc0e3fc1 PS4, Line 1797: codec_filter_run(&trans->cc.codecs);
Previously we discussed that codec_filter_run() should be called just before its result is used. […]
I think that was an unconclusive discussion, and probably I was not really happy about that 😊
What's the point in calling that function (which I guess is quite expensive) every time you need to use the result, instead of calling it when you *modify* the inputs?