Attention is currently required from: neels.

View Change

1 comment:

• File src/libmsc/gsm_04_08_cc.c:

  • Patch Set #4, Line 1797: codec_filter_run(&trans->cc.codecs);

    Previously we discussed that codec_filter_run() should be called just before its result is used. […]

    I think that was an unconclusive discussion, and probably I was not really happy about that 😊

    What's the point in calling that function (which I guess is quite expensive) every time you need to use the result, instead of calling it when you *modify* the inputs?

To view, visit change 30126. To unsubscribe, or for help writing mail filters, visit settings.