[S] Change in osmo-bts[master]: pcu_sock: forward PCU_VERSION only once

Attention is currently required from: laforge, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36018?usp=email ) Change subject: pcu_sock: forward PCU_VERSION only once ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/36018/comment/0febe25e_e2ac144f PS1, Line 10: is not active the PCU even sends the version number in regular In osmo-pcu there is the following mechanism: A BTS becomes active (bts->active == true) when pcu_rx_info_ind has run once. This means that osmo-bts has to send a valid info indication once and the BTS will be active. Then the text indications with the version in it cease. On the osmo-bts side we can see in pcu_rx_txt_ind what happens when PCU_VERSION is received. In particular the following is done: regenerate_si3_restoctets(bts); regenerate_si4_restoctets(bts); pcu_tx_si_all(bts); My first idea was to cease the PCU_VERSION txt indications when pcu_rx_info_ind is received the first time, regardless whether the BTS becomes active or not. However, I was afraid to do that since I am not sure if this would break something. If you think this initial idea is safe to do, then I can give it a try (and test it of course) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id82fe0504d0cbdf71473c1e7dfe6125a3471bd85 Gerrit-Change-Number: 36018 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 16:32:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment