16 Mar
2026
16 Mar
'26
9:44 a.m.
Attention is currently required from: dexter.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40200?usp=email )
Change subject: personalization: indicate default ParamSource per ConfigurableParameter ......................................................................
Patch Set 9:
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/40200/comment/5017d927_a08d38f5?usp=ema... : PS9, Line 362: default_source = param_source.IncDigitSource
The ICCID has a luhn checksum at the end. […]
the luhn is added implicitly, the editable part is without the luhn. I know this because we've already published ICCID on production SM-DP+ with this code.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40200?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie58d13bce3fa1aa2547cf3cee918c2f5b30a8b32
Gerrit-Change-Number: 40200
Gerrit-PatchSet: 9
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Sun, 15 Mar 2026 22:44:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter pmaier@sysmocom.de