pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792 )
Change subject: ranap_rab_ass: add decoder and rewrite functions for
RAB-AssignmentRequest/Response
......................................................................
Patch Set 14:
(1 comment)
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792/14/src/osmo-hnbgw/ranap_rab…
File src/osmo-hnbgw/ranap_rab_ass.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792/14/src/osmo-hnbgw/ranap_rab…
PS14, Line 198: int ranap_rab_ass_req_extract_inet_addr(struct osmo_sockaddr *addr,
uint8_t *rab_id, RANAP_RANAP_PDU_t *ranap_pdu)
Why not passing RANAP_RAB_AssignmentRequestIEs_t here instead of RANAP_RANAP_PDU_t?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26792
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I58b542bf23ff5e1db2ccf6833fec91d9ba332837
Gerrit-Change-Number: 26792
Gerrit-PatchSet: 14
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 17 Jan 2022 10:49:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment