Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39760?usp=email )
Change subject: clean up slot reset hack ......................................................................
Patch Set 1:
(1 comment)
File ccid_common/ccid_slot_fsm.c:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39760/comment/0336dbc0_813... : PS1, Line 108: void extern_fsm_reset_hack(struct ccid_slot *cs) so this removes the entire method that was added in the previous patch? Wouldn't it make sense to squash it then? Or if there is a reason to do it in two steps, a single line explaining the rationale in the commit log would be useful.