20 Sep
2022
20 Sep
'22
9:17 p.m.
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29424 )
Change subject: osmux: Log sendto() error ......................................................................
Patch Set 1:
(1 comment)
File src/common/osmux.c:
https://gerrit.osmocom.org/c/osmo-bts/+/29424/comment/48e15b14_1bfdb466 PS1, Line 96: strerror_r
Why not just using strerror()? osmo-bts is single-thread, and (I hope) will unlikely be multi-thread […]
There's nothing wrong with using strerror_r, and provides more robustness in case somebody wishes to move to multithread or reuse the code somewhere else.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29424
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I195ebe0fdb05195a7f3b1390630e83084b5dea3a
Gerrit-Change-Number: 29424
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 20 Sep 2022 19:17:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment