Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/28793 )
Change subject: trxcon: send pending TRXC messages in trx_if_flush_ctrl()
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
Are you sure this is really what we want? doesn't
look really sane to me if the conn is being closed […]
So we want to send POWEROFF
when a L1CTL connection is lost. The problem is that there can be other messages waiting
in the queue, which gets emptied in trx_if_flush_ctrl(). It works fine if there are no
pending messages, but does not when there is at least one sitting in the queue.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/28793
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I16d748b5194d381af0cd5ba9dbd4bfb33fc7d233
Gerrit-Change-Number: 28793
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Jul 2022 18:04:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment