Attention is currently required from: wbokslag.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-tetra/+/28592 )
Change subject: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/tuntap.h:
https://gerrit.osmocom.org/c/osmo-tetra/+/28592/comment/7a5f8af5_ea1fc532
PS1, Line 1: #ifndef TUNTAP_H
> I think "#pragma once" should be used
for all code developed in the last decade, but it's not crit […]
ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-tetra/+/28592
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: If920c15e4dafb48d5df70ce20532ecb19bd01ee3
Gerrit-Change-Number: 28592
Gerrit-PatchSet: 1
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Comment-Date: Tue, 19 Jul 2022 13:48:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: wbokslag <w.bokslag(a)midnightblue.nl>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment