Attention is currently required from: jolly.
fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095?usp=email )
Change subject: S1GW: Add test case to test release of failed e-RABs during handover resource allocation ......................................................................
Patch Set 2:
(5 comments)
File s1gw/S1GW_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/2ce934ba_5a6e8... : PS2, Line 1706: var ERabIdxList erabs_admitted; : for (var integer i := 0; i < lengthof(g_pars.erabs); i := i + 1) { : erabs_admitted[i] := i; : } See my comment about `f_ERabList_compose()` in previous patch.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/aa4db8fc_d9b31... : PS2, Line 1720: f_ConnHdlr_tx_handover_ack(erabs_admitted, mme_ue_id, enb_ue_id, erabs_failed); : log("[eNB -> S1GW] -> MME: HANDOVER REQUEST ACKNOWLEDGE"); We usually log first:
```suggestion log("[eNB -> S1GW] -> MME: HANDOVER REQUEST ACKNOWLEDGE"); f_ConnHdlr_tx_handover_ack(erabs_admitted, mme_ue_id, enb_ue_id, erabs_failed); ```
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/95bc691b_7daf0... : PS2, Line 1726: for (var integer i := 0; i < lengthof(erabs_admitted); i := i + 1) { : var ERabIdx idx := erabs_admitted[i]; : erabs[i] := g_pars.erabs[idx]; : } See my comment about `f_ERabList_compose()` in previous patch.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/690d213b_e6d6c... : PS2, Line 1736: for (var integer i := 0; i < lengthof(erabs_failed); i := i + 1) { : var ERabIdx idx := erabs_failed[i]; : erabs[i] := g_pars.erabs[idx]; : See my comment about `f_ERabList_compose()` in previous patch.
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41095/comment/5e6ae4a5_7a78e... : PS2, Line 962: for (var integer i := 0; i < lengthof(erabs_admitted); i := i + 1) { : var ERabIdx idx := erabs_admitted[i]; : erabs_left[i] := g_pars.erabs[idx]; : See my comment about `f_ERabList_compose()` in previous patch.