Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16355 )
Change subject: osmo_fsm: Ensure all state and event names are valid identifiers ......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7: When it comes to identifiers exposed over the CTRL interface, I am always wondering why don't we just implement a simple escaping for the CTRL itself, rather than restricting the FSM/CTR identifiers? I faced this problem while working on https://gerrit.osmocom.org/c/osmo-bts/+/25270. On the one had I have readability of the rate counter groups, on the other - inability of the CTRL interface to escape special symbols. I personally vote for readability, rather than identifiers that are hard to read.