22 Mar
2023
22 Mar
'23
10:40 p.m.
Attention is currently required from: pespin, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30878 )
Change subject: pcu_sock: don not continue when running out of TRX space ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I would personally abandon this patch, since merging it would hide a problem.
How does the patch hide the problem? Isn't the only difference that the existing code prints the message N number of times, and the new patch prints it only once? We still have the LOGL_NOTICE message (which should be an ERROR, by the way).
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30878
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If4d7eecaded22f86750283f7aa13072064724537
Gerrit-Change-Number: 30878
Gerrit-PatchSet: 1
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 22 Mar 2023 11:40:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment