Attention is currently required from: daniel, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email )
Change subject: osmo_io: Support rx of segments up to ~UINT16_MAX
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
this sounds like the kind of code where we definitely would want test coverage.
There is actually code coverage for regular segmentation under tests/osmo_io/osmo_io_test, but agree, I'll see if I can add a corner case triggering those.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/41911?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8c11a7edbed2335ada40a1f93d081041974c3586
Gerrit-Change-Number: 41911
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Thu, 22 Jan 2026 12:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org