dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/26823
)
Change subject: Initial IuUP support using proper FSMs
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/c/osmo-mgw/+/26823/2/src/libosmo-mgcp/mgcp_iuup.c
File src/libosmo-mgcp/mgcp_iuup.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/26823/2/src/libosmo-mgcp/mgcp_iuup.…
PS2, Line 229: /* FIXME: We probably need transcoding here?! Or at least look up AMR
modes and translate to related RFCI */
maybe it helps to explain a bit more what the problem is. There is a problem when the AMR
end uses a different active set then the IuUP end and we now rely on both having the same
active set by chance?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/26823
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6694a21480b25ab8f35d375295be6601ce38e31d
Gerrit-Change-Number: 26823
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 10 Jan 2022 15:41:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment