Jenkins Builder has posted comments on this change by neels. (
https://gerrit.osmocom.org/c/libasn1c/+/37990?usp=email )
Change subject: coverity CID#57682
......................................................................
Patch Set 2:
(2 comments)
File src/constr_CHOICE.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18208):
https://gerrit.osmocom.org/c/libasn1c/+/37990/comment/ee67d129_b4a424d3?usp… :
PS2, Line 1142: if(specs->ext_start == -1)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18208):
https://gerrit.osmocom.org/c/libasn1c/+/37990/comment/67320313_939f1a8e?usp… :
PS2, Line 1148: if(aper_open_type_put(elm->type, elm->per_constraints, memb_ptr,
po))
space required before the open parenthesis '('
--
To view, visit
https://gerrit.osmocom.org/c/libasn1c/+/37990?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Change-Id: I03b831e9e90591fd205e7d0e66314e1ce7061d24
Gerrit-Change-Number: 37990
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 03 Sep 2024 04:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No