laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/33778 )
Change subject: user_ifdhandler: Fix missing check of osmo_fd_register return val ......................................................................
user_ifdhandler: Fix missing check of osmo_fd_register return val
Fixes: CID#307514: Unchecked return value (CHECKED_RETURN) Change-Id: I99d7254b6cc3bf5ead800dafabc77a965857911c --- M src/client/user_ifdhandler.c 1 file changed, 12 insertions(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved
diff --git a/src/client/user_ifdhandler.c b/src/client/user_ifdhandler.c index 5e7fb7a..c6a9392 100644 --- a/src/client/user_ifdhandler.c +++ b/src/client/user_ifdhandler.c @@ -396,7 +396,8 @@
INIT_LLIST_HEAD(&ct->it_msgq); osmo_fd_setup(&ct->it_ofd, cfg->it_sock_fd, OSMO_FD_READ, &it_sock_fd_cb, ct, 0); - osmo_fd_register(&ct->it_ofd); + rc = osmo_fd_register(&ct->it_ofd); + OSMO_ASSERT(rc == 0);
/* ensure we get properly cleaned up if cancelled */ pthread_cleanup_push(client_pthread_cleanup, ct);