Attention is currently required from: msuraev.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/30196 )
Change subject: osmux: Set M bit in osmuxhdr if seqnum hole found encoding RTP pkts
......................................................................
Patch Set 3:
(1 comment)
File src/osmux_input.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/30196/comment/c09138df_fae8a92d
PS3, Line 156: ((state->circuit->last_transmitted_rtp_seq + 1) & 0xffff) !=
rtp_seqnum;
Where does magic 0xffff comes from?
sequence
numbers are uint16_t in RTP. I'm just doing the wraparound there, since
last_transmitted_rtp_seq is an int (in order to e able to mark it with -1 to indicate
unset).
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/30196
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I05b1eae400cb60d1f4e927f853619d5ff470163f
Gerrit-Change-Number: 30196
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Nov 2022 15:47:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment