24 Apr
2023
24 Apr
'23
1:26 p.m.
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32403 )
Change subject: Move resource allocation outside of tbf allocation ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/32403/comment/0d40371e_07938086 PS2, Line 1150:
missing " and ", multiple times in this patchset for the same comment
Done
File src/tbf.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/32403/comment/a07e9155_16cd4fc3 PS2, Line 582: #if 0
why keep this commented out code at all?
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/32403
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2856c946cb62d6e5372a1099b60e5f3456eb8fd4
Gerrit-Change-Number: 32403
Gerrit-PatchSet: 3
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 24 Apr 2023 11:26:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith osmith@sysmocom.de
Gerrit-MessageType: comment