[S] Change in osmo-msc[master]: IuCS: remove IuUP LOOPBACK hack

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/31693 ) Change subject: IuCS: remove IuUP LOOPBACK hack ...................................................................... IuCS: remove IuUP LOOPBACK hack Since osmo-mgw now supports IuUP properly, and since we indicate IUFP in the MGCP CRCX towars an IuCS RAN [1], we should no longer place the MGW endpoint in loopback mode to hack up an IuUP Initialization. This hack should have been removed along with [1]. [1] IUFP sent to MGW since this commit: commit 3a02d298049149f126fecc51e8445392cdb3b950 Refs: 1.8.0-13-g3a02d2980 Announce IuFP audio codec for UTRAN conns in CRCX towards MGW I7aca671e00ed27ac03f0d106b5a6b665a9bed4c1 Change-Id: I6446c64421e3e13e2b829293d031c98b99cd39a7 --- M src/libmsc/msc_a.c 1 file changed, 21 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/93/31693/1 diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c index a5ab2fb..e74a425 100644 --- a/src/libmsc/msc_a.c +++ b/src/libmsc/msc_a.c @@ -1755,12 +1755,6 @@ MSC_EV_CALL_LEG_RTP_LOCAL_ADDR_AVAILABLE, MSC_EV_CALL_LEG_RTP_COMPLETE); OSMO_ASSERT(cl); - - /* HACK: We put the connection in loopback mode at the beginning to - * trick the hNodeB into doing the IuUP negotiation with itself. - * This is a hack we need because osmo-mgw does not support IuUP yet, see OS#2459. */ - if (msc_a->c.ran->type == OSMO_RAT_UTRAN_IU) - cl->crcx_conn_mode[RTP_TO_RAN] = MGCP_CONN_LOOPBACK; } if (net->use_osmux != OSMUX_USAGE_OFF) { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31693 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6446c64421e3e13e2b829293d031c98b99cd39a7 Gerrit-Change-Number: 31693 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange