Attention is currently required from: pespin, fixeria, dexter.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31126
)
Change subject: abis_rsl: add support for sending IMMEDIATE ASSIGNMENT through PCH
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31126/comment/9bef5182_5156cd1f
PS11, Line 412: * the IMSI, which we need to compute the paging group */
(you often use a very short line width in comments ... doesn't your editor
auto-line-break them? i find the vim shift-V gw in conjunction with set textwidth=120
very useful to have to manually adjust almost nothing)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31126
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99
Gerrit-Change-Number: 31126
Gerrit-PatchSet: 11
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Feb 2023 03:34:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment