Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/34470?usp=email )
Change subject: abis_nm: handle NM_EV_SW_ACT_REP in ST_OP_DISABLED_{DEPENDENCY,OFFLINE}
......................................................................
Patch Set 1:
(3 comments)
File src/osmo-bsc/nm_bts_sm_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/83d44b3a_f4aedbfc
PS1, Line 123: case NM_EV_SW_ACT_REP:
why is configure_loop() not called here?
File src/osmo-bsc/nm_gprs_nsvc_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/f065715f_d55ee153
PS1, Line 179: case NM_EV_SW_ACT_REP:
missing configure_loop?
https://gerrit.osmocom.org/c/osmo-bsc/+/34470/comment/7fb00ccd_3bd3c342
PS1, Line 233: case NM_EV_SW_ACT_REP:
missing configure_loop?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/34470?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I00a423adcde5c34977f4c4dad920874687fa493c
Gerrit-Change-Number: 34470
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 21 Sep 2023 08:12:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment