Attention is currently required from: arehbein, fixeria, laforge, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email )
Change subject: tests: Test gsmtap logging if write queue fills up ......................................................................
Patch Set 3:
(5 comments)
File tests/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/b76ccc94_bd49d1b5 PS2, Line 18: logging/logging_test_gsmtap
This file needs to be updated properly: […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/a19cb23e_29d84576 PS2, Line 566: logging/logging_test
add the respective statement for `logging_test_gsmtap` here
Done
File tests/logging/logging_test_gsmtap.c:
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/673690cd_7398e8ee PS2, Line 3: 2008, 2009 by Holger Hans Peter Freyther zecke@selfish.org
I doubt it was Holger who wrote this test
He was the spiritual author but I get your point
File tests/logging/logging_test_gsmtap.err:
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/7ea7b0ba_1e827898 PS2, Line 108: 0x611000000328
I think we do patch stuff in output in some places already. […]
Thanks for the hint. It's even easier now since we're using the txqueue of osmo_io and it doesn't log any pointers.
File tests/testsuite.at:
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/60bbad5a_5646f7a1 PS2, Line 206: logging_test_gsmtap.ok
no such file?
Done