Attention is currently required from: arehbein, fixeria, laforge, pespin.

View Change

5 comments:

• File tests/Makefile.am:

  • Patch Set #2, Line 18: logging/logging_test_gsmtap

    This file needs to be updated properly: […]

    Done

  • Patch Set #2, Line 566: logging/logging_test

    add the respective statement for `logging_test_gsmtap` here

    Done

• File tests/logging/logging_test_gsmtap.c:

  • Patch Set #2, Line 3: 2008, 2009 by Holger Hans Peter Freyther <zecke@selfish.org>

    I doubt it was Holger who wrote this test

    He was the spiritual author but I get your point

• File tests/logging/logging_test_gsmtap.err:

  • Patch Set #2, Line 108: 0x611000000328

    I think we do patch stuff in output in some places already. […]

    Thanks for the hint. It's even easier now since we're using the txqueue of osmo_io and it doesn't log any pointers.

• File tests/testsuite.at:

  • Patch Set #2, Line 206: logging_test_gsmtap.ok

    no such file?

    Done

To view, visit change 34967. To unsubscribe, or for help writing mail filters, visit settings.