Attention is currently required from: osmith, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 )
Change subject: Add bsc_nat fsm ......................................................................
Patch Set 8:
(1 comment)
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/4a7c57be_a0f62978 PS8, Line 129: ss7_inst_free(bsc_nat->cn); This looks really strange. I'd expect a "free()" function called on a pointer to completely free the memory pointed by the ponter, so one should never use the pointer again. Yet I see you call talloc_free() on it afterwards. This is really confusing. My previous comment was in the line of doing: *_free(bsc_nat->cn); bsc_nat->cn = NULL;
since you are not freeing the bsc_nat parent object here, so it looks legityimate to set the pointer to null to avoid acessing the memory while the bsc_nat object is still alive.