Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/27218
)
Change subject: libosmo-tlv: add auto dec/enc to/from structs
......................................................................
Patch Set 4:
(1 comment)
File include/osmocom/tlv/tlv_dec_enc.h:
https://gerrit.osmocom.org/c/osmo-upf/+/27218/comment/8cdf5acb_4cde9102
PS4, Line 60: OSMO_TLV_NESTED_IES_ORDERED_SAME = 0,
Ok now with the comment I understand. Maybe use "ORDERING_SAME" instead,
otherwise it's confusing as it seems a kind of ordered way, and ORDERED_SAME can
actually mean UNORDERED in some cases(outer IE).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/27218
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I65de793105882a452124ee58adb0e58469e6e796
Gerrit-Change-Number: 27218
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Mar 2022 15:43:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment