Attention is currently required from: laforge, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28896 )
Change subject: abis_om2000: duplicate nmstate of bb_trxc mo to trx mo ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/osmo-bsc/abis_om2000.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/28896/comment/c401f2ac_c72b2e6a PS2, Line 2303: memset(&nsd_bb_transc, 0, sizeof(nsd));
You mean basically copying nsd (trx) to nsd_bb_transc (bb_transc) I think thats problematic. […]
Not really, because the virtual bbtransc will always have the same state as the trx, so you an copy it from the trx one.
I think this code can really be cleaned up further, but anyway just adding +1.