Attention is currently required from: osmith, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662 )
Change subject: Add bsc_nat fsm ......................................................................
Patch Set 5:
(2 comments)
File include/osmocom/bsc_nat/bsc_nat_fsm.h:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/25a5d941_7a701e1b PS5, Line 22: void bsc_nat_fsm_start(struct bsc_nat *bsc_nat); The API is a bit weird, because you return fi in bsc_nat_fsm_alloc, which is then assigned externally to bsc_nat->fi, and then in these other functions you pass bsc_nat and do bsc_nat->fi from it.
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/26662/comment/845a1a19_3b5c8a6c PS5, Line 136: static void st_stopped_on_enter(struct osmo_fsm_inst *fi, uint32_t prev_state) Please put the on_enter function above the event one.